-
Notifications
You must be signed in to change notification settings - Fork 421
refactor(data-classes): clean up internal logic for APIGatewayAuthorizerResponse #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
heitorlessa
merged 6 commits into
aws-powertools:develop
from
gyft:refactor/api-authorizer
Sep 9, 2021
Merged
refactor(data-classes): clean up internal logic for APIGatewayAuthorizerResponse #643
heitorlessa
merged 6 commits into
aws-powertools:develop
from
gyft:refactor/api-authorizer
Sep 9, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the internal logic for `APIGatewayAuthorizerResponse` and update the internal docs.
Codecov Report
@@ Coverage Diff @@
## develop #643 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 116 116
Lines 4846 4853 +7
Branches 265 266 +1
========================================
+ Hits 4845 4852 +7
Partials 1 1
Continue to review full report at Codecov.
|
heitorlessa
suggested changes
Aug 22, 2021
Update the docs and add a deny all response
Add `from_route_arn` to build APIGatewayAuthorizerResponse Add a relaxed pylintrc
@heitorlessa - i addressed your feedback in this PR. |
heitorlessa
approved these changes
Sep 9, 2021
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Sep 28, 2021
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: docs(event-handler): document catch-all routes (aws-powertools#705) chore: add python 3.9 support docs: add team behind it and email ISSUE-693: Use ExpressionAttributeNames in _put_record (aws-powertools#697) feat(validator): include missing data elements from a validation error (aws-powertools#686) chore(deps-dev): bump mkdocs-material from 7.2.8 to 7.3.0 (aws-powertools#695) chore(deps-dev): bump mkdocs-material from 7.2.6 to 7.2.8 (aws-powertools#682) chore(deps-dev): bump flake8-bugbear from 21.4.3 to 21.9.1 (aws-powertools#676) chore(deps): bump boto3 from 1.18.38 to 1.18.41 (aws-powertools#677) chore(deps-dev): bump radon from 4.5.2 to 5.1.0 (aws-powertools#673) chore(deps): bump boto3 from 1.18.32 to 1.18.38 (aws-powertools#671) refactor(data-classes): clean up internal logic for APIGatewayAuthorizerResponse (aws-powertools#643) fix(data-classes): use correct asdict funciton (aws-powertools#666) chore(deps-dev): bump xenon from 0.7.3 to 0.8.0 (aws-powertools#669) chore: bump to 1.20.2 fix: Fix issue with strip_prefixes (aws-powertools#647) chore(deps-dev): bump mkdocs-material from 7.2.4 to 7.2.6 (aws-powertools#665) chore(deps): bump boto3 from 1.18.26 to 1.18.32 (aws-powertools#663) chore(deps-dev): bump pytest from 6.2.4 to 6.2.5 (aws-powertools#662) chore(license): Add THIRD-PARTY-LICENSES (aws-powertools#641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
internal
Maintenance changes
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Changes:
APIGatewayAuthorizerResponse
DENY_ALL_RESPONSE
usageIdentifierKey
for Rest API responses onlyfrom_route_arn
to build APIGatewayAuthorizerResponse from anarn
Update Example
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/utilities/data_classes.md